feat: set-namespace without kyaml/rnode dependencies #769
Conversation
yuwenma
force-pushed
the
set-namespace-v2
branch
2 times, most recently
from
faf138b
to
02329db
Compare
yuwenma
force-pushed
the
set-namespace-v2
branch
6 times, most recently
from
1bbbcb0
to
7a862ab
Compare
yuwenma
force-pushed
the
set-namespace-v2
branch
11 times, most recently
from
216052f
to
696ba29
Compare
yuwenma
force-pushed
the
set-namespace-v2
branch
3 times, most recently
from
30b96e0
to
c115f50
Compare
| var subjects []*Subject | ||
| o.GetOrDie(&subjects, "subjects") | ||
| for _, s := range subjects { | ||
| if s.Name == "default" { |
There was a problem hiding this comment.
As discussed in this doc, there are 2 scenarios to update the namespace field:
- subject is a ServiceAccount and its name is "default"
- subject is a ServiceAccount and its name is not "default", but there is a ServiceAccount object that has the matching name.
It's a superset of what you currently have.
There was a problem hiding this comment.
Yeah, do you mind me making the change in the following PR. I have some other logic relevant to this need to add as well. Basically, the new set-namespace only expect a single namespace exists. It raises error if multiple namespace is detected. Thus, here the namespace will be updated if and only if it is a ServiceAccount kind and the existing namespace matches the found one.
There was a problem hiding this comment.
I'm OK with doing this logic in a followup PR.
yuwenma
force-pushed
the
set-namespace-v2
branch
2 times, most recently
from
701d255
to
6efd22e
Compare
yuwenma
force-pushed
the
set-namespace-v2
branch
from
7c18805
to
6efd22e
Compare
|
The e2e CI is failing since we need the change in https://github.com/GoogleContainerTools/kpt-functions-catalog/pull/778/files#diff-ffb14a1d95b60197845214f7c645cfb58afc4d1de90eb37587be970ebe7c6f57R8 to make it passing. |
|
@yuwenma you can rebase this PR, it should be passing after that. |
yuwenma
force-pushed
the
set-namespace-v2
branch
2 times, most recently
from
062d7d0
to
01efe36
Compare
This function re-implements the set-namespace function but removes all kyaml dependencies.
It's not ready to be merged until its dependent functions are merged in kpt-functions-sdk